Conversation
Add opt-in Micrometer registry configuration for Spring Boot 2, 3, and 4 when the sentry-micrometer artifact is present.\n\nExpose polling configuration, register the Sentry registry with Spring's composite registry, and verify active and passive metric delivery through sample system tests.\n\nCo-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
This was referenced Sep 15, 2026
📲 Install BuildsAndroid
|
Update Spring Boot system test expectations to match the Sentry registry's dot naming convention. Co-Authored-By: Claude <noreply@anthropic.com>
Document generation-specific starter coordinates so Spring Boot 2 and 3 users can adapt the Boot 4 setup example. Co-Authored-By: Claude <noreply@anthropic.com>
lbloder
reviewed
Sep 22, 2026
| @Bean(destroyMethod = "close") | ||
| @ConditionalOnMissingBean(SentryMeterRegistry.class) | ||
| public @NotNull SentryMeterRegistry sentryMeterRegistry( | ||
| final @NotNull IScopes scopes, final @NotNull SentryProperties properties) { |
Collaborator
There was a problem hiding this comment.
scopes is never used in the SentryMicrometerConfiguration classes. is this just to make sure that IScopes are initialized before the registry is created?
lbloder
reviewed
Sep 22, 2026
| return "count metric increased"; | ||
| } | ||
|
|
||
| @GetMapping("micrometer") |
Collaborator
There was a problem hiding this comment.
Any reason this is only added in spring-boot, but not in the spring-boot-jakarta and spring-boot-4 variants?
Member
Author
There was a problem hiding this comment.
we can add samples to other versions too.
9 tasks
Use the supplied IScopes for metric recording and diagnostic logging instead of bypassing it through the static Sentry API. Default standalone constructors to ScopesAdapter so current-context resolution is preserved. Pass the Spring scopes bean through all three Boot integrations while retaining initialization ordering. Cover injected metrics, logging, and Spring wiring with regression tests. Refs #6116 Co-Authored-By: Claude <noreply@anthropic.com>
adinauer
added a commit
that referenced
this pull request
Sep 23, 2026
Merge the Spring Boot registry scopes change from #6116 into #6155. Use the same injected scopes for registration filtering and recording so custom scopes do not accidentally inherit global ignored-metric options. Resolve test imports, supply options in injected-scope fixtures, and cover filtering with distinct global and injected ignore lists. Preserve the existing logging defaults and explicit override behavior. Refs #6116 Refs #6155 Co-Authored-By: Claude <noreply@anthropic.com>
Copy the Boot 2 Micrometer endpoint and secondary SimpleMeterRegistry into the Jakarta and Boot 4 samples. Verify that a single recording reaches both Sentry and the secondary registry, including exported tags and SDK integration metadata. Run the six metrics system tests for each of Boot 2, 3, and 4 against the sample applications and mock Sentry server: all 18 pass. Refs #6116 Co-Authored-By: Claude <noreply@anthropic.com>
adinauer
added a commit
that referenced
this pull request
Sep 23, 2026
Merge the Boot 3 and Boot 4 sample endpoints and dual-registry system tests from #6116 into the ignored-metrics branch. Keep the top of the stack in sync without rewriting its history. Verify all 18 metrics system tests against Boot 2, 3, and 4 with the ignored-metrics defaults applied. Formatting and API checks also pass. Refs #6116 Refs #6155 Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Micrometer)
📜 Description
Closes #6149
Add opt-in Micrometer integration for Spring Boot 2, 3, and 4.
When
sentry-micrometerand Micrometer are on the classpath, settingsentry.micrometer.enabled=truecreates aSentryMeterRegistrybean that Spring adds to its composite registry.sentry.micrometer.poll-interval-milliscontrols passive polling and defaults to 60 seconds.The artifact remains optional and is not added transitively by the existing starters. The Spring Boot samples add Actuator and verify that active HTTP metrics and passively polled process metrics reach real Sentry metric envelopes.
💡 Motivation and Context
Spring Boot applications commonly use Micrometer through Actuator. Thin conditional configuration lets those applications add Sentry as another metrics destination without replacing existing registries or enabling the integration merely because a class happens to be present.
Importing the configuration from the existing Sentry auto-configuration keeps lifecycle and initialization ordering aligned across all three supported Spring Boot generations.
💚 How did you test it?
The Spring Boot 2, 3, and 4
MetricsSystemTestsuites also passed against the repository mock Sentry server on port 18080. They verifyhttp.server.requestsactive metrics and passively polledprocess.uptimemetrics in captured envelopes.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Complete cross-SDK documentation and evaluate build-plugin installation separately.